lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 23 Oct 2013 00:18:08 +0200 From: Peter Zijlstra <peterz@...radead.org> To: Vaidyanathan Srinivasan <svaidy@...ux.vnet.ibm.com> Cc: Mike Galbraith <bitbucket@...ine.de>, Paul Turner <pjt@...gle.com>, Ingo Molnar <mingo@...nel.org>, Michael Neuling <mikey@...ling.org>, Benjamin Herrenschmidt <benh@...nel.crashing.org>, linux-kernel@...r.kernel.org, Anton Blanchard <anton@...ba.org>, Preeti U Murthy <preeti@...ux.vnet.ibm.com>, linuxppc-dev@...ts.ozlabs.org Subject: Re: [PATCH 2/3] sched: Fix asymmetric scheduling for POWER7 On Mon, Oct 21, 2013 at 05:14:52PM +0530, Vaidyanathan Srinivasan wrote: > kernel/sched/fair.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > index 12f0eab..828ed97 100644 > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -5821,8 +5821,8 @@ static inline int nohz_kick_needed(struct rq *rq, int cpu) > goto need_kick_unlock; > } > > - if (sd->flags & SD_ASYM_PACKING && nr_busy != sg->group_weight > - && (cpumask_first_and(nohz.idle_cpus_mask, > + if (sd->flags & SD_ASYM_PACKING && > + (cpumask_first_and(nohz.idle_cpus_mask, > sched_domain_span(sd)) < cpu)) > goto need_kick_unlock; > > Ahh, so here you remove the nr_busy usage.. this patch should really go before the first one that makes this all weird and funny. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists