linux-kernel - Re: [PATCH -next] pinctrl: tb10x: fix the error handling in tb10x_pinctrl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdbHcCKAJko3RLsnyuDCR01g6kHLSobewj_QffwpRA+NZg@mail.gmail.com>
Date:	Wed, 23 Oct 2013 10:45:18 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Wei Yongjun <weiyj.lk@...il.com>
Cc:	Grant Likely <grant.likely@...aro.org>,
	Rob Herring <rob.herring@...xeda.com>,
	Wei Yongjun <yongjun_wei@...ndmicro.com.cn>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] pinctrl: tb10x: fix the error handling in tb10x_pinctrl_probe()

On Mon, Oct 21, 2013 at 4:55 AM, Wei Yongjun <weiyj.lk@...il.com> wrote:

> From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
>
> This patch fix the error handling in tb10x_pinctrl_probe():
>  - devm_ioremap_resource() return ERR_PTR() and never return NULL
>  - remove the dev_err call to avoid redundant error message
>  - pinctrl_register() returns NULL not ERR_PTR()
>
> Signed-off-by: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>

Thanks, patch applied!

Hm this seems to be an easy mistake to do. I have discussed
in the past whether we can make the compiler verify
error pointers semantically and warn on problems.

I don't know if that is achieveable though :-(

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/