linux-kernel - Async runtime put in __device_release

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <5267A0DF.7080604@ti.com>
Date:	Wed, 23 Oct 2013 13:11:43 +0300
From:	Tomi Valkeinen <tomi.valkeinen@...com>
To:	Ulf Hansson <ulf.hansson@...aro.org>
CC:	Kevin Hilman <khilman@...aro.org>,
	"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
	Linus Walleij <linus.walleij@...aro.org>,
	Archit Taneja <archit@...com>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Async runtime put in __device_release_driver()

Hi,

I was debugging why clocks were left enabled after removing omapdss
driver, and I found this commit:

fa180eb448fa263cf18dd930143b515d27d70d7b (PM / Runtime: Idle devices
asynchronously after probe|release)

I don't understand how that is supposed to work.

When a driver is removed, instead of using pm_runtime_put_sync() the
commit uses pm_runtime_put(), so the runtime_suspend call is queued. But
who is going to handle the queued suspend call, as the driver is already
removed? At least in my case, obviously nobody, as I only get
runtime_resume call in my driver, never the runtime_suspend.

Is there something I need to add to my driver to make this work, or
should that part of the patch be reverted?

 Tomi

Download attachment "signature.asc" of type "application/pgp-signature" (902 bytes)