linux-kernel - Re: userspace firmware load fails with current linux-next

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACVXFVM0oUi0m8sGtRGX_VS6wouvo5=N7XN=s477290pzKKC2w@mail.gmail.com>
Date:	Wed, 23 Oct 2013 18:48:06 +0800
From:	Ming Lei <ming.lei@...onical.com>
To:	Lothar Waßmann <LW@...o-electronics.de>
Cc:	Tejun Heo <tj@...nel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: userspace firmware load fails with current linux-next

On Wed, Oct 23, 2013 at 6:43 PM, Lothar Waßmann <LW@...o-electronics.de> wrote:

> The patch as is produces a build error, because 'size' is only defined
> after the 'if' statement.

Sorry for that, :-)

>
> The modified patch below works for me.
>
> diff --git a/fs/sysfs/file.c b/fs/sysfs/file.c
> index 5d818df..709d6f5 100644
> --- a/fs/sysfs/file.c
> +++ b/fs/sysfs/file.c
> @@ -277,7 +277,7 @@ static ssize_t sysfs_write_file(struct file *file, const char __user *user_buf,
>         ssize_t len = min_t(size_t, count, PAGE_SIZE);
>         char *buf;
>
> -       if (sysfs_is_bin(of->sd)) {
> +       if (sysfs_is_bin(of->sd) && file_inode(file)->i_size) {
>                 loff_t size = file_inode(file)->i_size;
>
>                 if (size <= *ppos)

OK, thanks for your test, and will prepare a formal one later.


Thanks,
--
Ming Lei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/