linux-kernel - Re: [PATCH] skd: Fix checkpatch ERRORS and removed unused functions.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20131023120232.GB14598@kernel.dk>
Date:	Wed, 23 Oct 2013 13:02:32 +0100
From:	Jens Axboe <axboe@...nel.dk>
To:	Akhil Bhansali <Akhil.Bhansali@...t.com>
Cc:	OS Engineering <osengineering@...c-inc.com>,
	Ramprasad Chinthekindi <Ramprasad.Chinthekindi@...t.com>,
	"jmoyer@...hat.com" <jmoyer@...hat.com>,
	"'linux kernel (linux-kernel@...r.kernel.org)'" 
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] skd: Fix checkpatch ERRORS and removed unused functions.

On Wed, Oct 23 2013, Akhil Bhansali wrote:
> From dcd25c7128e14c90abb6a5d61e0a9ae9b26b6904 Mon Sep 17 00:00:00 2001
> From: Akhil Bhansali <bhansaliakhil@...il.com>
> Date: Wed, 23 Oct 2013 14:45:34 +0530
> Subject: [PATCH] [PATCH] Fix checkpatch ERRORS and removed unused functions.

In the future, please ensure that patches are sanity cleaned. There's a
double [PATCH] in that subject, and you should prefix the first line
with the driver/area being modified.

I committed it as:

skd: Fix checkpatch ERRORS and removed unused functions.

> This patch fixes checkpatch.pl errors for assignment in if condition.
> It also removes unused readq / readl function calls.
> 
> As Andrew had disabled the compilation of drivers for 32 bit,
> I have modified format specifiers in few VPRINTKs to avoid warnings
> during 64 bit compilation.
> Signed-off-by: Akhil Bhansali <abhansali@...c-inc.com>
> Reviewed-by: Ramprasad Chinthekindi <rchinthekindi@...c-inc.com>

Leave a line between the commit message and the signed-off/reviewed
lines.

> PROPRIETARY-CONFIDENTIAL INFORMATION INCLUDED
> 
> This electronic transmission, and any documents attached hereto, may
> contain confidential, proprietary and/or legally privileged
> information. The information is intended only for use by the recipient
> named above. If you received this electronic message in error, please
> notify the sender and delete the electronic message. Any disclosure,
> copying, distribution, or use of the contents of information received
> in error is strictly prohibited, and violators will be pursued
> legally.

And you might want to look into getting rid of this if possible, you are
posting to public lists...

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/