linux-kernel - Re: [GIT PULL] SCSI fixes for 3.12-rc6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1382530790.16097.29.camel@dabdike.quadriga.com>
Date:	Wed, 23 Oct 2013 13:19:50 +0100
From:	James Bottomley <James.Bottomley@...senPartnership.com>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-scsi <linux-scsi@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PULL] SCSI fixes for 3.12-rc6

On Wed, 2013-10-23 at 13:07 +0100, Linus Torvalds wrote:
> On Wed, Oct 23, 2013 at 12:27 PM, James Bottomley
> <James.Bottomley@...senpartnership.com> wrote:
> >
> > The patch is available here:
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scsi-fixes
> 
> No it's not. "Already up-to-date.".

Um, sorry, forgot to make a tag.  Done now.

> Also, even if it was, I'm not feeling the reason to pull it. "Cleanup
> sprintf formatting of firmware version"? "Remove superfluous mask of
> pcie_cap_reg"? Seriously?

Well, yes, provided the new driver exception still holds.  The eas2r
driver was added in the last merge window so it qualifies.  Previously
you'd said that drivers that weren't previously in the tree could have
changes and cleanups added even at the -rc stage ... if you're reversing
this, I can pull the eas2r updates into the misc tree insead.

> Multi-hundred-line pull requests that come in this late had better
> look a bit more serious than that.
> 
> There's *HUNDREDS* of lines of changes, all of which seems to come
> from the change to use the (admittedly much superior) native bit
> handling fucntions, instead of the shit-for-brains abortion that is
> "esas2r_lock_set/clear_flags()"
> 
> And I see why you'd want to get rid of that horrible crap, but I see
> absolutely _zero_ reason to do it in -rc7.
> 
> As far as I can tell from the patch, a few lines are for actual
> problems like oopses. And the rest is pure and utter garbage that
> should have happened during the merge window.
> 
> So I literally *cannot* pull this, because the git tree doesn't
> contain what you said it contains. But even if it did, I would not
> *want* to pull this kind of completely brainless crap.
> 
> You need to curse at the people who send you this kind of crap.
> Seriously. This is not acceptablee timing.

OK, so is the new driver exception gone then?

James


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/