linux-kernel - Re: [PATCH] ARM: dts: Add max77686 RTC interrupt to cros5250-common

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <777cfa1b95066d03b19252ac1b6eac2d@www.loen.fr>
Date:	Wed, 23 Oct 2013 14:31:24 +0100
From:	Marc Zyngier <marc.zyngier@....com>
To:	Doug Anderson <dianders@...omium.org>
Cc:	Kukjin Kim <kgene.kim@...sung.com>,
	Russell King <linux@....linux.org.uk>,
	Tomasz Figa <t.figa@...sung.com>,
	<linux-kernel@...r.kernel.org>, Olof Johansson <olof@...om.net>,
	<linux-arm-kernel@...ts.infradead.org>,
	Rahul Sharma <rahul.sharma@...sung.com>
Subject: Re: [PATCH] ARM: dts: Add max77686 RTC interrupt to cros5250-common

On 2013-10-23 14:11, Doug Anderson wrote:
> Without the interrupt you'll get problems if you enable
> CONFIG_RTC_DRV_MAX77686.  Setup the interrupt properly in the device
> tree.

Awesome! Thanks for fixing this, Doug. My Chromebook is much happier 
now!

> Signed-off-by: Doug Anderson <dianders@...omium.org>

Tested-by: Marc Zyngier <marc.zyngier@....com>

         M.

> ---
>  arch/arm/boot/dts/cros5250-common.dtsi | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
>
> diff --git a/arch/arm/boot/dts/cros5250-common.dtsi
> b/arch/arm/boot/dts/cros5250-common.dtsi
> index dc259e8b..9b186ac 100644
> --- a/arch/arm/boot/dts/cros5250-common.dtsi
> +++ b/arch/arm/boot/dts/cros5250-common.dtsi
> @@ -27,6 +27,13 @@
>  		i2c2_bus: i2c2-bus {
>  			samsung,pin-pud = <0>;
>  		};
> +
> +		max77686_irq: max77686-irq {
> +			samsung,pins = "gpx3-2";
> +			samsung,pin-function = <0>;
> +			samsung,pin-pud = <0>;
> +			samsung,pin-drv = <0>;
> +		};
>  	};
>
>  	i2c@...60000 {
> @@ -35,6 +42,11 @@
>
>  		max77686@09 {
>  			compatible = "maxim,max77686";
> +			interrupt-parent = <&gpx3>;
> +			interrupts = <2 0>;
> +			pinctrl-names = "default";
> +			pinctrl-0 = <&max77686_irq>;
> +			wakeup-source;
>  			reg = <0x09>;
>
>  			voltage-regulators {

-- 
Fast, cheap, reliable. Pick two.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/