linux-kernel - Re: [PATCH] Generic WorkQueue Engine (GenWQE) device driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131023134059.GB21936@sepie.suse.cz>
Date:	Wed, 23 Oct 2013 15:40:59 +0200
From:	Michal Marek <mmarek@...e.cz>
To:	Frank Haverkamp <haver@...ux.vnet.ibm.com>
Cc:	Frank Haverkamp <haver@...t.ibm.com>, linux-kernel@...r.kernel.org,
	arnd@...db.de, gregkh@...uxfoundation.org, cody@...ux.vnet.ibm.com,
	schwidefsky@...ibm.com, utz.bacher@...ibm.com, jsvogt@...ibm.com,
	MIJUNG@...ibm.com, cascardo@...ux.vnet.ibm.com, michael@...ra.de
Subject: Re: [PATCH] Generic WorkQueue Engine (GenWQE) device driver

On Wed, Oct 23, 2013 at 03:15:54PM +0200, Frank Haverkamp wrote:
> Hi Marek,
> 
> it took a little while, but here are the requested changes to our
> driver:
> 
> Rework comments:
>  o Removed __DATE__ macros as suggested by Michal Marek

Hi Frank,

did you send an old version of the patch? There are still two ocurences
of __DATE__:


> +static int genwqe_probe(struct pci_dev *pci_dev,
> +			const struct pci_device_id *id)
> +{
[...]
> +	dev_info(&pci_dev->dev, "GenWQE driver version: %s (build %s) %s%u\n",
> +		 DRV_VERS_STRING, __DATE__, GENWQE_DEVNAME, cd->card_idx);

and

> +static ssize_t show_card_info(struct device *dev,
> +			      struct device_attribute *attr, char *buf)
> +{
[...]
> +	len += scnprintf(&buf[len], PAGE_SIZE - len,
> +			 "GenWQE driver version: %s (build %s)\n"
> +			 "    Device Name/Type: %s %s CardIdx: %d\n"
> +			 "    SLU/APP Config  : 0x%016llx/0x%016llx\n"
> +			 "    Build Date/Type : %u/%x/%u %s\n"
> +			 "    Base Clock      : %u MHz\n"
> +			 "    Arch/SVN Release: %u/%llx\n"
> +			 "    Bitstream       : %llx\n",
> +			 DRV_VERS_STRING, __DATE__, dev_name(&pci_dev->dev),


Thanks,
Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/