linux-kernel - RE: [PATCH] arc: kernel: add default extern variable 'screen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <C2D7FE5348E1B147BCA15975FBA23075152B30@IN01WEMBXA.internal.synopsys.com>
Date:	Wed, 23 Oct 2013 13:47:56 +0000
From:	Vineet Gupta <Vineet.Gupta1@...opsys.com>
To:	Chen Gang <gang.chen@...anux.com>, Arnd Bergmann <arnd@...db.de>,
	"sachin.kamat@...aro.org" <sachin.kamat@...aro.org>,
	Paul Gortmaker <paul.gortmaker@...driver.com>,
	James Hogan <james.hogan@...tec.com>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] arc: kernel: add default extern variable 'screen_info'
 in "setup.c"

Apologies for top posting !

NAK.

ARC will never have VGA console. You need to add !ARC to relevant Kconfig. However that approach is frowned upon in general. The current way to doing such things is to define a new Kconfig item which relevant arches can select.

-Vineet
________________________________________
From: Chen Gang [gang.chen@...anux.com]
Sent: Wednesday, October 23, 2013 4:39 PM
To: vgupta@...opsys.com; Arnd Bergmann; sachin.kamat@...aro.org; Paul Gortmaker; James Hogan
Cc: linux-kernel@...r.kernel.org
Subject: [PATCH] arc: kernel: add default extern variable 'screen_info' in "setup.c"

Add default 'screen_info' just like some of other architectures (e.g.
cris, score, sh, tile), or can not pass compiling.

The related error (with allmodconfig):

  drivers/built-in.o: In function `vgacon_save_screen':
  drivers/video/console/vgacon.c:1347: undefined reference to `screen_info'
  drivers/video/console/vgacon.c:1348: undefined reference to `screen_info'
  drivers/built-in.o: In function `vgacon_resize':
  drivers/video/console/vgacon.c:1314: undefined reference to `screen_info'
  drivers/video/console/vgacon.c:1315: undefined reference to `screen_info'
  drivers/built-in.o: In function `vgacon_switch':
  drivers/video/console/vgacon.c:820: undefined reference to `screen_info'
  drivers/built-in.o:drivers/video/console/vgacon.c:840: more undefined references to `screen_info' follow


Signed-off-by: Chen Gang <gang.chen@...anux.com>
---
 arch/arc/kernel/setup.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/arch/arc/kernel/setup.c b/arch/arc/kernel/setup.c
index 2c68bc7e..07130f3 100644
--- a/arch/arc/kernel/setup.c
+++ b/arch/arc/kernel/setup.c
@@ -15,6 +15,7 @@
 #include <linux/cpu.h>
 #include <linux/of_fdt.h>
 #include <linux/cache.h>
+#include <linux/screen_info.h>
 #include <asm/sections.h>
 #include <asm/arcregs.h>
 #include <asm/tlb.h>
@@ -37,6 +38,8 @@ struct task_struct *_current_task[NR_CPUS];   /* For stack switching */

 struct cpuinfo_arc cpuinfo_arc700[NR_CPUS];

+struct screen_info screen_info;
+

 void read_arc_build_cfg_regs(void)
 {
--
1.7.7.6
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/