linux-kernel - Re: [PATCHv3 3/3] Input: twl4030-pwrbutton: simplify driver using devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 23 Oct 2013 12:44:20 -0500
From:	Felipe Balbi <balbi@...com>
To:	Aaro Koskinen <aaro.koskinen@....fi>
CC:	Sebastian Reichel <sre@...ian.org>,
	Sebastian Reichel <sre@...g0.de>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Grant Likely <grant.likely@...aro.org>,
	Rob Herring <rob.herring@...xeda.com>,
	Peter Ujfalusi <peter.ujfalusi@...com>,
	Sachin Kamat <sachin.kamat@...aro.org>,
	<linux-input@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<devicetree@...r.kernel.org>
Subject: Re: [PATCHv3 3/3] Input: twl4030-pwrbutton: simplify driver using
 devm_*

On Wed, Oct 23, 2013 at 08:25:24PM +0300, Aaro Koskinen wrote:
> Hi,
> 
> On Wed, Oct 23, 2013 at 06:47:15PM +0200, Sebastian Reichel wrote:
> >  static int __exit twl4030_pwrbutton_remove(struct platform_device *pdev)
> >  {
> >  	struct input_dev *pwr = platform_get_drvdata(pdev);
> > -	int irq = platform_get_irq(pdev, 0);
> >  
> > -	free_irq(irq, pwr);
> >  	input_unregister_device(pwr);
> 
> The same bug still exists. You don't need to unregister manually any more,
> this whole function can be just reduced to "return 0;".

then it can be removed altogether, no ?

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)