linux-kernel - Re: [PATCH 8/8] sound: Remove OOM message after input_allocate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hk3h3nhoi.wl%tiwai@suse.de>
Date:	Thu, 24 Oct 2013 11:26:21 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Joe Perches <joe@...ches.com>
Cc:	linux-kernel@...r.kernel.org, Jaroslav Kysela <perex@...ex.cz>,
	alsa-devel@...a-project.org
Subject: Re: [PATCH 8/8] sound: Remove OOM message after input_allocate_device

At Wed, 23 Oct 2013 12:14:54 -0700,
Joe Perches wrote:
> 
> Emitting an OOM message isn't necessary after input_allocate_device
> as there's a generic OOM and a dump_stack already done.
> 
> Signed-off-by: Joe Perches <joe@...ches.com>

Thanks, applied.


Takashi

> ---
>  sound/pci/hda/hda_beep.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/sound/pci/hda/hda_beep.c b/sound/pci/hda/hda_beep.c
> index 63c9909..20d065a 100644
> --- a/sound/pci/hda/hda_beep.c
> +++ b/sound/pci/hda/hda_beep.c
> @@ -151,10 +151,8 @@ static int snd_hda_do_attach(struct hda_beep *beep)
>  	int err;
>  
>  	input_dev = input_allocate_device();
> -	if (!input_dev) {
> -		printk(KERN_INFO "hda_beep: unable to allocate input device\n");
> +	if (!input_dev)
>  		return -ENOMEM;
> -	}
>  
>  	/* setup digital beep device */
>  	input_dev->name = "HDA Digital PCBeep";
> -- 
> 1.8.1.2.459.gbcd45b4.dirty
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/