linux-kernel - Re: [PATCH v2] Input: add regulator haptic driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1382610609.1559.12.camel@linux-fkkt.site>
Date:	Thu, 24 Oct 2013 12:30:09 +0200
From:	Oliver Neukum <oneukum@...e.de>
To:	"hyunhee.kim" <hyunhee.kim@...sung.com>
Cc:	'Dmitry Torokhov' <dmitry.torokhov@...il.com>,
	broonie@...nsource.wolfsonmicro.com, peter.ujfalusi@...com,
	wfp5p@...ginia.edu, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	kyungmin.park@...sung.com,
	'Aristeu Sergio Rozanski Filho' <aris@...vo.org>
Subject: Re: [PATCH v2] Input: add regulator haptic driver

On Thu, 2013-10-24 at 18:26 +0900, hyunhee.kim wrote:
> Hi, 
> 
> Thanks for your review.
> I resent patch v3 after removing wrong wrapping.
> 
> I made one toggle function because enable/disable functions have redundant codes and another reviewer suggested it.
> Is it better to separate it into two functions?

Linus doesn't like parameters affecting behavior.

	Regards
		Oliver


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/