linux-kernel - Re: [PATCH] arc: kernel: add default extern variable 'screen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdWCrLaAiOtgKtH5yb82XvoDJ15BEUB8gyQS2-CkjQqHTw@mail.gmail.com>
Date:	Thu, 24 Oct 2013 13:51:38 +0200
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Chen Gang <gang.chen@...anux.com>
Cc:	Vineet Gupta <Vineet.Gupta1@...opsys.com>,
	Arnd Bergmann <arnd@...db.de>,
	"sachin.kamat@...aro.org" <sachin.kamat@...aro.org>,
	Paul Gortmaker <paul.gortmaker@...driver.com>,
	James Hogan <james.hogan@...tec.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Will Deacon <will.deacon@....com>,
	Catalin Marinas <Catalin.Marinas@....com>
Subject: Re: [PATCH] arc: kernel: add default extern variable 'screen_info' in "setup.c"

Hi Chen,

On Thu, Oct 24, 2013 at 1:23 PM, Chen Gang <gang.chen@...anux.com> wrote:
>> Lot's of negative dependencies are missing for VGA_CONSOLE.
>> I think only alpha, some arm, ia64, some mips, some powerpc, and x86
>> may use it.
>>
>
> in "arch" sub-directory, contents 13/30 (43.3%) architectures contents
> VGA_CONSOLE.
>
>   1 alpha/kernel/setup.c:137:struct screen_info screen_info = {
>   2 arm/kernel/setup.c:743:struct screen_info screen_info = {
>   3 cris/kernel/setup.c:28:struct screen_info screen_info;
>   4 ia64/kernel/setup.c:79:struct screen_info screen_info;
>   5 m32r/kernel/setup.c:55:struct screen_info screen_info = {
>   6 mips/kernel/setup.c:43:struct screen_info screen_info;
>   7 powerpc/kernel/setup-common.c:88:struct screen_info screen_info = {
>   8 score/kernel/setup.c:37:struct screen_info screen_info;
>   9 sh/kernel/setup.c:68:struct screen_info screen_info;
>  10 sparc/kernel/setup_64.c:66:struct screen_info screen_info = {
>  11 sparc/kernel/setup_32.c:53:struct screen_info screen_info = {
>  12 tile/kernel/setup.c:54:struct screen_info screen_info;
>  13 x86/kernel/setup.c:220:struct screen_info screen_info;
>  14 xtensa/kernel/setup.c:55:struct screen_info screen_info = { 0, 24, 0, 0, 0, 80, 0, 0, 0, 24, 1, 16};
>
> It seems most of pc and servers support VGA_CONSOLE.

I'm quite sure many of these just provide a screen_info to make vgacon compile.

>> Compare this to a shiny new feature that available on all new architectures,
>> but not on a few old one. There it makes sense to have the negative
>> dependencies on the old architectures, that will never have the new feature.
>> While new architectures have enabled it by default.
>>
>
> Excuse me, my English is not quite well, I do not quite understand your
> meaning, but it seems not quite important for our discussing, so I just
> skip it, now.

Sorry, I should stop writing complex sentences.
For now, nevermind. There aren't that many real cases like this.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/