linux-kernel - Re: [PATCH] bcache: Fixed incorrect order of arguments to bio_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20131024120406.GY14598@kernel.dk>
Date:	Thu, 24 Oct 2013 13:04:06 +0100
From:	Jens Axboe <axboe@...nel.dk>
To:	Kent Overstreet <kmo@...erainc.com>
Cc:	torvalds@...ux-foundation.org, linux-kernel@...r.kernel.org,
	linux-bcache@...r.kernel.org
Subject: Re: [PATCH] bcache: Fixed incorrect order of arguments to
 bio_alloc_bioset()

On Tue, Oct 22 2013, Kent Overstreet wrote:
> Signed-off-by: Kent Overstreet <kmo@...erainc.com>
> Cc: linux-stable <stable@...r.kernel.org> # >= v3.10
> ---
>  drivers/md/bcache/request.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/md/bcache/request.c b/drivers/md/bcache/request.c
> index b6a74bc..2a7f0dd 100644
> --- a/drivers/md/bcache/request.c
> +++ b/drivers/md/bcache/request.c
> @@ -1000,7 +1000,7 @@ static void request_write(struct cached_dev *dc, struct search *s)
>  
>  		if (bio->bi_rw & REQ_FLUSH) {
>  			/* Also need to send a flush to the backing device */
> -			struct bio *flush = bio_alloc_bioset(0, GFP_NOIO,
> +			struct bio *flush = bio_alloc_bioset(GFP_NOIO, 0,
>  							     dc->disk.bio_split);
>  
>  			flush->bi_rw	= WRITE_FLUSH;

Woops... Added.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/