linux-kernel - READ/WRITE definitions in drivers/spi/spi-omap-100k.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131024124631.GA14517@mtj.dyndns.org>
Date:	Thu, 24 Oct 2013 13:46:31 +0100
From:	Tejun Heo <tj@...nel.org>
To:	Grant Likely <grant.likely@...retlab.ca>
Cc:	Wolfram Sang <w.sang@...gutronix.de>,
	Linus Walleij <linus.walleij@...aro.org>,
	linux-kernel@...r.kernel.org
Subject: READ/WRITE definitions in drivers/spi/spi-omap-100k.c

Hey, guys.

I was modifying includes in a core header file and got duplicate macro
definition warnings on READ / WRITE in drivers/spi/spi-omap-100k.c.
Apparently that driver defines READ / WRITE as macros and assigns the
opposite values to them from the usual READ / WRITE constants defined
in include/linux/fs.h.

I just skimmed through it and there doesn't seem to be any user of the
macros.  Can we *please* remove these?  Please note that READ / WRITE
defined in include/linux/fs.h is something which is widely used
throughout the kernel and there are multiple interfaces which take
those constants.  Re-defining them in the other way around in a driver
file can lead to subtle issues and just is a bad idea.  In general,
refraining from using generic symbols without any qualitification in
low level drivers would be nice.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/