linux-kernel - Re: [PATCH 4/8] input: Remove OOM message after input_allocate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131024184612.GC3512@pengutronix.de>
Date:	Thu, 24 Oct 2013 20:46:12 +0200
From:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
To:	Joe Perches <joe@...ches.com>
Cc:	Kukjin Kim <kgene.kim@...sung.com>,
	Ferruh Yigit <fery@...ress.com>,
	Wan ZongShun <mcuos.com@...il.com>,
	Andrey Moiseev <o2g.org.ru@...il.com>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	linux-kernel@...r.kernel.org, Josh Wu <josh.wu@...el.com>,
	linux-samsung-soc@...r.kernel.org,
	Henrik Rydberg <rydberg@...omail.se>,
	Ben Dooks <ben-linux@...ff.org>, linux-input@...r.kernel.org,
	Pau Oliva Fora <pof@...ack.org>,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 4/8] input: Remove OOM message after input_allocate_device

On Thu, Oct 24, 2013 at 11:43:38AM -0700, Joe Perches wrote:
> On Thu, 2013-10-24 at 20:26 +0200, Uwe Kleine-König wrote:
> > Hello Joe,
> > 
> > On Wed, Oct 23, 2013 at 12:14:50PM -0700, Joe Perches wrote:
> > > Emitting an OOM message isn't necessary after input_allocate_device
> > > as there's a generic OOM and a dump_stack already done.
> > > 
> > > [...]
> > > Signed-off-by: Joe Perches <joe@...ches.com>
> > > diff --git a/drivers/input/joystick/as5011.c b/drivers/input/joystick/as5011.c
> > > index 005d852..3b9c709 100644
> > > --- a/drivers/input/joystick/as5011.c
> > > +++ b/drivers/input/joystick/as5011.c
> > > @@ -254,8 +254,6 @@ static int as5011_probe(struct i2c_client *client,
> > >  	as5011 = kmalloc(sizeof(struct as5011_device), GFP_KERNEL);
> > >  	input_dev = input_allocate_device();
> > >  	if (!as5011 || !input_dev) {
> > > -		dev_err(&client->dev,
> > > -			"Can't allocate memory for device structure\n");
> > Don't know if that can happen, but if as5011 is NULL but input_dev isn't
> > the message would still be sensible, wouldn't it? There are several more
> > that suffer the same "problem".
> 
> Any k.alloc without __GFP_NOWARN does a generic OOM message
> and a dump_stack() so there could already be 2 messages anyway.
Then mention that in the commit log if you still want this patch?!

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/