linux-kernel - Re: [PATCH 01/11] Export __smp_call_function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 25 Oct 2013 12:45:33 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Jens Axboe <axboe@...nel.dk>
Cc:	linux-kernel@...r.kernel.org, hch@...radead.org,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH 01/11] Export __smp_call_function_single()


* Jens Axboe <axboe@...nel.dk> wrote:

> On Fri, Oct 25 2013, Ingo Molnar wrote:
> > 
> > * Jens Axboe <axboe@...nel.dk> wrote:
> > 
> > > The blk-mq core and the blk-mq null driver uses it.
> > > 
> > > Cc: Ingo Molnar <mingo@...nel.org>
> > > Signed-off-by: Jens Axboe <axboe@...nel.dk>
> > > ---
> > >  kernel/smp.c | 1 +
> > >  1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/kernel/smp.c b/kernel/smp.c
> > > index 0564571..9de461e 100644
> > > --- a/kernel/smp.c
> > > +++ b/kernel/smp.c
> > > @@ -340,6 +340,7 @@ void __smp_call_function_single(int cpu, struct call_single_data *csd,
> > >  	}
> > >  	put_cpu();
> > >  }
> > > +EXPORT_SYMBOL(__smp_call_function_single);
> > 
> > I agree with exporting it to in-kernel users, but I'd prefer a _GPL 
> > export for newly exported symbols that are for in-kernel use.
> 
> Agree, it should be _GPL. I will update the patch. Can I add your
> acked-by?

Sure:

Acked-by: Ingo Molnar <mingo@...nel.org>

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/