linux-kernel - Re: [PATCH] skd: Replaced custom debug PRINTKs with pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131025112430.GE6285@kernel.dk>
Date:	Fri, 25 Oct 2013 12:24:30 +0100
From:	Jens Axboe <axboe@...nel.dk>
To:	Joe Perches <joe@...ches.com>
Cc:	Ramprasad Chinthekindi <Ramprasad.Chinthekindi@...t.com>,
	Akhil Bhansali <Akhil.Bhansali@...t.com>,
	"jmoyer@...hat.com" <jmoyer@...hat.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Amit Phansalkar <Amit.Phansalkar@...t.com>
Subject: Re: [PATCH] skd: Replaced custom debug PRINTKs with pr_debug

On Thu, Oct 24 2013, Joe Perches wrote:
> On Thu, 2013-10-24 at 12:53 +0100, Jens Axboe wrote:
> > On Thu, Oct 24 2013, Ramprasad Chinthekindi wrote:
> > > Hi Jens,
> > > 
> > > I'm resending the patch to replace custom debug macros with
> > > pr_debug(). Kindly please review and apply the patch.  Thanking you.
> > 
> > Thanks, that's a nice improvement. Applied.
> 
> Is it really much of an improvement?
> 
> It leaves possible different behavior with
> skdev->dbg_level/skd_dbg_level set without
> linkage to a few printks now.
> 
> It also doesn't make use of dynamic debug's
> +f/+l capability to and always emits
> __func__/__LINE__.

It's an improvement from a private FOOPRINTK() macro. Feel free to send
in further improvements.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/