linux-kernel - [PATCH 2/2] blk-mq: add maps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 25 Oct 2013 16:42:37 +0200
From:	Matias Bjorling <m@...rling.me>
To:	axboe@...nel.dk
Cc:	linux-kernel@...r.kernel.org, Matias Bjorling <m@...rling.me>
Subject: [PATCH 2/2] blk-mq: add maps_tags fn and add usage

Now that the tags mapping allows shared mapping, update blk-mq to allow
the driver to control initialization of the tags structure.

Signed-off-by: Matias Bjorling <m@...rling.me>
---
 block/blk-mq.c         | 11 +++++++----
 include/linux/blk-mq.h | 12 ++++++++++++
 2 files changed, 19 insertions(+), 4 deletions(-)

diff --git a/block/blk-mq.c b/block/blk-mq.c
index f21ec96..9e25555 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -1093,7 +1093,7 @@ static size_t order_to_size(unsigned int order)
 }
 
 static int blk_mq_init_rq_map(struct blk_mq_hw_ctx *hctx,
-			      unsigned int reserved_tags, int node)
+			      struct blk_mq_reg *reg, int node)
 {
 	unsigned int i, j, entries_per_page, max_order = 4;
 	size_t rq_size, left;
@@ -1150,7 +1150,7 @@ static int blk_mq_init_rq_map(struct blk_mq_hw_ctx *hctx,
 		}
 	}
 
-	if (i < (reserved_tags + BLK_MQ_TAG_MIN))
+	if (i < (reg->reserved_tags + BLK_MQ_TAG_MIN))
 		goto err_rq_map;
 	else if (i != hctx->queue_depth) {
 		hctx->queue_depth = i;
@@ -1158,7 +1158,10 @@ static int blk_mq_init_rq_map(struct blk_mq_hw_ctx *hctx,
 					__func__, i);
 	}
 
-	hctx->tags = blk_mq_init_tags(hctx->queue_depth, reserved_tags, node);
+	if (reg->ops->map_tags)
+		hctx->tags = reg->ops->map_tags(hctx, reg, node);
+	else
+		hctx->tags = blk_mq_init_tags(hctx->queue_depth, reg->reserved_tags, node);
 	if (!hctx->tags) {
 err_rq_map:
 		blk_mq_free_rq_map(hctx);
@@ -1198,7 +1201,7 @@ static int blk_mq_init_hw_queues(struct request_queue *q,
 						blk_mq_hctx_notify, hctx);
 		blk_mq_register_cpu_notifier(&hctx->cpu_notifier);
 
-		if (blk_mq_init_rq_map(hctx, reg->reserved_tags, node))
+		if (blk_mq_init_rq_map(hctx, reg, node))
 			break;
 
 		/*
diff --git a/include/linux/blk-mq.h b/include/linux/blk-mq.h
index 746042ff..eb6df6a 100644
--- a/include/linux/blk-mq.h
+++ b/include/linux/blk-mq.h
@@ -66,6 +66,8 @@ typedef struct blk_mq_hw_ctx *(alloc_hctx_fn)(struct blk_mq_reg *,unsigned int);
 typedef void (free_hctx_fn)(struct blk_mq_hw_ctx *, unsigned int);
 typedef int (init_hctx_fn)(struct blk_mq_hw_ctx *, void *, unsigned int);
 typedef void (exit_hctx_fn)(struct blk_mq_hw_ctx *, unsigned int);
+typedef struct blk_mq_tags *(map_tags_fn)(struct blk_mq_hw_ctx *,
+					  struct blk_mq_reg *, unsigned int node);
 
 struct blk_mq_ops {
 	/*
@@ -96,6 +98,12 @@ struct blk_mq_ops {
 	 */
 	init_hctx_fn		*init_hctx;
 	exit_hctx_fn		*exit_hctx;
+
+	/*
+	 * If a tags structure is to be shared between multiple request queues,
+	 * allow the driver to initialize or reuse a tags structure.
+	 */
+	map_tags_fn		*map_tags;
 };
 
 enum {
@@ -138,6 +146,10 @@ void blk_mq_stop_hw_queue(struct blk_mq_hw_ctx *hctx);
 void blk_mq_start_hw_queue(struct blk_mq_hw_ctx *hctx);
 void blk_mq_start_stopped_hw_queues(struct request_queue *q);
 
+struct blk_mq_tags *blk_mq_init_tags(unsigned int total_tags,
+				     unsigned int reserved_tags, int node);
+void blk_mq_init_tags_shared(struct blk_mq_tags *tags);
+
 /*
  * Driver command data is immediately after the request. So subtract request
  * size to get back to the original request.
-- 
1.8.3.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/