linux-kernel - [PATCH v1] Set 1-1 P2M for PCI BARs and MCFG regions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1382713401-4882-1-git-send-email-konrad.wilk@oracle.com>
Date:	Fri, 25 Oct 2013 11:03:19 -0400
From:	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
To:	linux-kernel@...r.kernel.org, xen-devel@...ts.xensource.com,
	Santosh.Jodh@...rix.com, JBeulich@...e.com,
	boris.ostrovsky@...cle.com, david.vrabel@...rix.com,
	mukesh.rathor@...cle.com, xhejtman@....muni.cz,
	yuval.shaia@...cle.com
Subject: [PATCH v1] Set 1-1 P2M for PCI BARs and MCFG regions - if needed.

These two patches check and mark the P2M region (if needed) for
PCIe BARs and for MCFG regions.

The reason this is required is that anytime any driver calls ioremap_pfn
or constructs PTEs - we consult the P2M. If we find that for the PFN
the region is INVALID_P2M_ENTRY we return the 0 PFN. If we find that
for the PFN the region is IDENTITY_FRAME we ruturn the PFN (so
pfn_to_mfn(pfn) == pfn) - which makes device drivers happy.

We initially set this up when scanning the E820 and selecting the
E820_RSRV and the gaps between the E820 regions as such. But we also
have to careful as there are potential balloon regions so we can't
assume that region past the E820 is all 1-1.

There are alternative ways of solving this:
 1) Mark all regions past the E820 and past the balloon regions as
    1-1 regions. That requires some surgery in the P2M code to deal
    with the p2m_mid_missing and p2m_mid_identity (new) for the different
    levels in the tree. The code is not for the faint of heart.

 2). Assume that INVALID_P2M_ENTRY is considered 1-1. That would require
    auditing of the code and also making sure that any xen_privcmd_mmap
    calls use the m2p_add_override. However there are some
    valid cases in which we need to check for INVALID_P2M_ENTRY -
    balloon driver - that might be relaxed. However again the P2M code
    and the ABI it places are not for the faint of the heart.

As such these two patches just add extra code to set the IDENTITY_FRAME
on the BARs and for MCFG areas.


 drivers/xen/balloon.c           |  19 +++++
 drivers/xen/pci.c               | 164 +++++++++++++++++++++++++++++++++++++++-
 include/xen/balloon.h           |   1 +
 include/xen/interface/physdev.h |  11 +++
 4 files changed, 192 insertions(+), 3 deletions(-)


Konrad Rzeszutek Wilk (2):
      xen/p2m: Create identity mappings for PFNs beyound E820 and PCI BARs
      xen/mcfg: Call PHYSDEVOP_pci_mmcfg_reserved for MCFG areas and setup 1-1 P2M

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/