linux-kernel - Re: [PATCH] mfd: ti_am335x_tscadc: avoid possible deadlock of reg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20131025152922.GA4263@gmail.com>
Date:	Fri, 25 Oct 2013 20:29:24 +0500
From:	"Zubair Lutfullah :" <zubair.lutfullah@...il.com>
To:	Lee Jones <lee.jones@...aro.org>
Cc:	Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	linux-kernel@...r.kernel.org,
	Zubair Lutfullah <zubair.lutfullah@...il.com>,
	Felipe Balbi <balbi@...com>, kishon@...com
Subject: Re: [PATCH] mfd: ti_am335x_tscadc: avoid possible deadlock of
 reg_lock

On Tue, Oct 22, 2013 at 06:13:59PM +0100, Lee Jones wrote:
> On Tue, 22 Oct 2013, Sebastian Andrzej Siewior wrote:
> 
> > Since the addition of continuous sampling mode and shared irq support,
> > the reg_lock lock can be taken with and without interrupts. This patch
> > uses the *_irq* variant which should be used in order to avaoid a deadlock.
> > 
> > Cc: Zubair Lutfullah <zubair.lutfullah@...il.com>
> > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
> > ---
> >  drivers/mfd/ti_am335x_tscadc.c | 12 ++++++++----
> >  1 file changed, 8 insertions(+), 4 deletions(-)
> 
> Good catch. Applied, thanks.

Had noticed this and forgot. My bad..

Thanks for catching it.

Zubair
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/