linux-kernel - Re: [PATCH v4] Input: add regulator haptic driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131025082944.GK18506@sirena.org.uk>
Date:	Fri, 25 Oct 2013 09:29:44 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Hyunhee Kim <hyunhee.kim@...sung.com>
Cc:	dmitry.torokhov@...il.com, peter.ujfalusi@...com,
	wfp5p@...ginia.edu, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	kyungmin.park@...sung.com
Subject: Re: [PATCH v4] Input: add regulator haptic driver

On Fri, Oct 25, 2013 at 03:29:51PM +0900, Hyunhee Kim wrote:
> From: Hyunhee Kim <hyunhee.kim@...sung.com>
> Date: Wed, 9 Oct 2013 16:21:36 +0900
> Subject: [PATCH] Input: add regulator haptic driver

This is OK from a regulator point of view though there's still a lot of
use of regulator devm_ and input devm_ that could happen - it wasn't
just the kzalloc(), it was most of the allocations in the driver.

You also have some word wrapping in your e-mail so the patch probably
won't apply.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)