linux-kernel - Re: [PATCH V5 REPOST] mfd: add support for ams AS3722 PMIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131026161902.GA7698@lee--X1>
Date:	Sat, 26 Oct 2013 09:19:02 -0700
From:	Lee Jones <lee.jones@...aro.org>
To:	Grant Likely <grant.likely@...aro.org>
Cc:	Laxman Dewangan <ldewangan@...dia.com>, sameo@...ux.intel.com,
	broonie@...nel.org, linus.walleij@...aro.org,
	akpm@...ux-foundation.org, devicetree@...r.kernel.org,
	linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-gpio@...r.kernel.org, rtc-linux@...glegroups.com,
	rob.herring@...xeda.com, mark.rutland@....com, pawel.moll@....com,
	swarren@...dotorg.org, rob@...dley.net,
	ijc+devicetree@...lion.org.uk,
	Florian Lobmaier <florian.lobmaier@....com>
Subject: Re: [PATCH V5 REPOST] mfd: add support for ams AS3722 PMIC

Hi Grant,

> > Acked-by: Stephen Warren <swarren@...dia.com>
> > Signed-off-by: Laxman Dewangan <ldewangan@...dia.com>
> > Signed-off-by: Florian Lobmaier <florian.lobmaier@....com>
> > Signed-off-by: Lee Jones <lee.jones@...aro.org>

<snip>

> > +    Optional properties:
> > +    -------------------
> > +	The input supply of regulators are the optional properties on the
> > +	regulator node. The input supply of these regulators are provided
> > +	through following properties:
> > +		vsup-sd2-supply: Input supply for SD2.
> > +		vsup-sd3-supply: Input supply for SD3.
> > +		vsup-sd4-supply: Input supply for SD4.
> > +		vsup-sd5-supply: Input supply for SD5.
> > +		vin-ldo0-supply: Input supply for LDO0.
> > +		vin-ldo1-6-supply: Input supply for LDO1 and LDO6.
> > +		vin-ldo2-5-7-supply: Input supply for LDO2, LDO5 and LDO7.
> > +		vin-ldo3-4-supply: Input supply for LDO3 and LDO4.
> > +		vin-ldo9-10-supply: Input supply for LDO9 and LDO10.
> > +		vin-ldo11-supply: Input supply for LDO11.
> 
> What is the data in these properties? The documentation isn't clear.
> 
> In principle, the binding looks okay to me.

The properties to which you refer are standard regulator supply
bindings specified here [1]. Specifically:

  "<name>-supply: phandle to the parent supply/regulator node"

The DT portion has already been Acked by Stephen and applied by me.

[1] Documentation/devicetree/bindings/regulator/regulator.txt

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/