linux-kernel - Re: [PATCH 2/5] fat: add fat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87hac2yga3.fsf@devron.myhome.or.jp>
Date:	Sun, 27 Oct 2013 22:50:12 +0900
From:	OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
To:	Namjae Jeon <linkinjeon@...il.com>
Cc:	akpm@...ux-foundation.org, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org, a.sahrawat@...sung.com,
	Namjae Jeon <namjae.jeon@...sung.com>
Subject: Re: [PATCH 2/5] fat: add fat_fallocate operation

Namjae Jeon <linkinjeon@...il.com> writes:

> diff --git a/fs/fat/inode.c b/fs/fat/inode.c
> index 578a5db..2211489 100644
> --- a/fs/fat/inode.c
> +++ b/fs/fat/inode.c
> @@ -491,6 +491,13 @@ EXPORT_SYMBOL_GPL(fat_build_inode);
>  
>  static void fat_evict_inode(struct inode *inode)
>  {
> +	struct super_block *sb = inode->i_sb;
> +
> +	/* Release unwritten fallocated blocks on file release. */
> +	if (round_up(inode->i_size, sb->s_blocksize) <
> +	    MSDOS_I(inode)->i_disksize && inode->i_nlink != 0)
> +		fat_truncate_blocks(inode, inode->i_size);
> +
>  	truncate_inode_pages(&inode->i_data, 0);
>  	if (!inode->i_nlink) {
>  		inode->i_size = 0;

This would be better to move after truncate_inode_pages(). And as part
of "else".

	if (!inode->i_nlink) {
        	...
        } else {
        	/* here */
        }

And inode->i_size should be ->mmu_private?
-- 
OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/