linux-kernel - Re: [PATCH 2/4] perf tools: Split -G and --call-graph for top command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <526D3294.4000402@gmail.com>
Date:	Sun, 27 Oct 2013 09:34:44 -0600
From:	David Ahern <dsahern@...il.com>
To:	Jiri Olsa <jolsa@...hat.com>, linux-kernel@...r.kernel.org
CC:	Corey Ashford <cjashfor@...ux.vnet.ibm.com>,
	Ingo Molnar <mingo@...e.hu>,
	Namhyung Kim <namhyung@...nel.org>,
	Paul Mackerras <paulus@...ba.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Andi Kleen <andi@...stfloor.org>,
	Adrian Hunter <adrian.hunter@...el.com>
Subject: Re: [PATCH 2/4] perf tools: Split -G and --call-graph for top command

On 10/26/13 8:25 AM, Jiri Olsa wrote:
> diff --git a/tools/perf/Documentation/perf-top.txt b/tools/perf/Documentation/perf-top.txt
> index c16a09e..d311974 100644
> --- a/tools/perf/Documentation/perf-top.txt
> +++ b/tools/perf/Documentation/perf-top.txt
> @@ -143,20 +143,12 @@ Default is to monitor all CPUS.
>   --asm-raw::
>   	Show raw instruction encoding of assembly instructions.
>
> --G [type,min,order]::
> +-G::
> +	Enables call-graph (stack chain/backtrace) recording.
> +
>   --call-graph::
> -        Display call chains using type, min percent threshold and order.
> -	type can be either:
> -	- flat: single column, linear exposure of call chains.
> -	- graph: use a graph tree, displaying absolute overhead rates.
> -	- fractal: like graph, but displays relative rates. Each branch of
> -		 the tree is considered as a new profiled object.
> -
> -	order can be either:
> -	- callee: callee based call graph.
> -	- caller: inverted caller based call graph.
> -
> -	Default: fractal,0.5,callee.
> +	Setup and enable call-graph (stack chain/backtrace) recording,
> +	implies -g.

implies '-G' for perf-top. Given that perf-top is recording and 
analyzing events shouldn't the analysis options (caller/callee and 
callgraph type) be kept here?

Really should have callchains be consistent across perf-commands as -g.

Other than that: Tested-Reviewed-by: David Ahern <dsahern@...il.com>

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/