linux-kernel - Re: [PATCH] X86: MM: Add PAT Type write-through in combination with mtrr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131027165159.GD1617@thinkpad.fritz.box>
Date:	Sun, 27 Oct 2013 17:51:59 +0100
From:	Andreas Werner <wernerandy@....de>
To:	Borislav Petkov <bp@...en8.de>
Cc:	tglx@...utronix.de, mingo@...hat.com, hpa@...or.com,
	x86@...nel.org, dave@...ux.vnet.ibm.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] X86: MM: Add PAT Type write-through in combination with
 mtrr

On Sun, Oct 27, 2013 at 02:34:01PM +0100, Borislav Petkov wrote:
> On Sun, Oct 27, 2013 at 01:55:25PM +0100, Andreas Werner wrote:
> > This patch adds the Write-through memory type in combination with mtrr.
> > If you call ioremap_cache to request cachable memory (write-back) the
> > function tries to set the PAT to write-back only if the mtrr setting of
> > the requested region is also marked as Write-Back.
> > If the mttr regions are marked e.g. as Write-through or with other
> > types, the function will always return UC- memory.
> > 
> > If you check the Intel document " IA-32 SDM vol 3a table Effective
> > Memory Type", there
> > are many other combinations possible.
> > 
> > This patch will only add the following combination:
> >   PAT=Write-Back + MTRR=Write-Through = Effective Memory of
> > Write-Through
> 
> And yet the code below returns WB for WT MTRR type which can't be
> right since having a write-through mapping cannot be compatible with
> write-back as the last caches writes into the cache instead of writing
> them through to memory.
> 
> Why do you even care about WT? Are you trying to fix a bug or what?
>

Im currently working on an ethernet driver for our own ETH core.
The problem is that one requirement is to not use DMA to transmit 
or receive the data. This means the that the ethernet buffers are not 
located in the main memory. They are located in the FPGA internal RAM.

To transmit or receive a frame, i have to read or write to mmio to get the data.

Intel has introduced the instruction "clflush" which can flush a cache line.
I want to use the caches for those mmio (eth buffer) to speed up the transmit/receive
and to transmit/receive using PCIe bursts (read/write).

The problem was if i set the buffer to Write-Back and call clflush on 
those mmio-addresses, the system crashed without any output.
I found this articel 
http://software.intel.com/en-us/forums/topic/393070

After that i configured the transmit buffers to be Write-Combining (only write to that adresses) 
using ioremap_wc, and the receive buffers to be Write-Through (ioremap_cache + mtrr Write-Through + this kernel patch) 
everything worked as expected.

On PCIe Tracer i can see the bursts on read/write on my device with this configuration.

I know that this is a special use case but there is also one person more out there,
who use that configuration. But why not allow this setting in the kernel? It is
also mentioned in the Intel IA32 document.

I know that there is also an instruction called "movntdqa" but this is not support on my platform
(Intel E680) this instruction was introduced in SSE3. So i can not use it.

If you need more detailed informations please ask me.

Best Regards
Andy

> > Tested on - Intel (R) Atom E680 (Tunnel Creek)
> >           - Intel (R) Core(TM)2 Duo
> > 
> > Signed-off-by: Andreas Werner <wernerandy@....de>
> > ---
> >  arch/x86/mm/pat.c | 11 ++++++++---
> >  1 file changed, 8 insertions(+), 3 deletions(-)
> > 
> > diff --git a/arch/x86/mm/pat.c b/arch/x86/mm/pat.c
> > index 6574388..9cfe107 100644
> > --- a/arch/x86/mm/pat.c
> > +++ b/arch/x86/mm/pat.c
> > @@ -149,10 +149,15 @@ static unsigned long pat_x_mtrr_type(u64 start, u64 end, unsigned long req_type)
> >  		u8 mtrr_type;
> >  
> >  		mtrr_type = mtrr_type_lookup(start, end);
> > -		if (mtrr_type != MTRR_TYPE_WRBACK)
> > -			return _PAGE_CACHE_UC_MINUS;
> >  
> > -		return _PAGE_CACHE_WB;
> > +		switch (mtrr_type) {
> > +		case MTRR_TYPE_WRBACK:
> > +		case MTRR_TYPE_WRTHROUGH:
> > +		  return _PAGE_CACHE_WB;
> > +
> > +		default:
> > +		  return _PAGE_CACHE_UC_MINUS;
> > +		}
> >  	}
> >  
> >  	return req_type;
> 
> -- 
> Regards/Gruss,
>     Boris.
> 
> Sent from a fat crate under my desk. Formatting is fine.
> --
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/