linux-kernel - Re: [PATCH v2] mmc:sdhci-pci: Add Support of O2Mirco/BayHubTech SD Host

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <868uxeoohu.fsf@void.printf.net>
Date:	Sun, 27 Oct 2013 13:02:53 +0000
From:	Chris Ball <cjb@...top.org>
To:	Peter Guo <peter.guo@...hubtech.com>
Cc:	Adrian Hunter <adrian.hunter@...el.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Bill Pemberton <wfp5p@...ginia.edu>,
	"Guennadi Liakhovetski" <g.liakhovetski@....de>,
	"linux-mmc\@vger.kernel.org" <linux-mmc@...r.kernel.org>,
	"linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>,
	Samuel Guan <samuel.guan@...hubtech.com>,
	Xiaoguang Yu <xiaoguang.yu@...hubtech.com>,
	Shirley Her <shirley.her@...hubtech.com>,
	Yuxiang Wan <yuxiang.wan@...hubtech.com>,
	"Adam Lee" <adam.lee@...onical.com>
Subject: Re: [PATCH v2] mmc:sdhci-pci: Add Support of O2Mirco/BayHubTech SD Host

Hi Peter,

On Wed, Oct 23 2013, Peter Guo wrote:
> Do you have any comments on this patch?

It would be nice if there were fewer magic constants in the patch, and
adding another 200 lines to sdhci-pci seems to suggest that it might
be time to split it out into sdhci-pci-o2micro.c.

Thanks,

- Chris.
-- 
Chris Ball   <cjb@...top.org>   <http://printf.net/>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/