[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <526E2233.3020304@nvidia.com>
Date: Mon, 28 Oct 2013 10:37:07 +0200
From: Terje Bergström <tbergstrom@...dia.com>
To: Arto Merilainen <amerilainen@...dia.com>,
"thierry.reding@...il.com" <thierry.reding@...il.com>
CC: "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCHv2 0/4] gpu: host1x: Add syncpoint base support
On 14.10.2013 15:21, Arto Merilainen wrote:
> The host1x driver uses currently syncpoints statically from host1x point of
> view. If we do a wait inside a job, it always has a constant value to wait.
> host1x supports also doing relative syncpoint waits with respect to syncpoint
> bases. This allows doing multiple operations inside a single submit and
> waiting an operation to complete before moving to next one.
>
> This set of patches adds support for syncpoint bases to host1x driver and
> enables the support for gr2d client.
>
> I have tested the series using the host1x test application (available at [0],
> function test_wait_base() in tests/tegra/host1x/tegra_host1x_test.c) on cardhu.
> I would appreciate help in reviewing the series and testing the patches
> on other boards.
>
> Changes in v2:
> - Reordered various code blocks to improve code consistency
> - Functions host1x_syncpt_alloc() and host1x_syncpt_request() take now a single
> bitfield argument instead of separate boolean arguments
> - Added a separate ioctl call for querying the base associated with some
> syncpoint
>
> [0] https://gitorious.org/linux-host1x/libdrm-host1x
>
> Arto Merilainen (4):
> gpu: host1x: Add 'flags' field to syncpt request
> gpu: host1x: Add syncpoint base support
> drm/tegra: Deliver syncpoint base to user space
> drm/tegra: Reserve base for gr2d
>
> drivers/gpu/host1x/dev.h | 2 ++
> drivers/gpu/host1x/drm/drm.c | 25 +++++++++++++
> drivers/gpu/host1x/drm/gr2d.c | 2 +-
> drivers/gpu/host1x/hw/channel_hw.c | 19 ++++++++++
> drivers/gpu/host1x/hw/hw_host1x01_uclass.h | 6 ++++
> drivers/gpu/host1x/syncpt.c | 58 +++++++++++++++++++++++++-----
> drivers/gpu/host1x/syncpt.h | 10 +++++-
> include/uapi/drm/tegra_drm.h | 26 +++++++++-----
> 8 files changed, 128 insertions(+), 20 deletions(-)
>
The series,
Reviewed-by: Terje Bergstrom <tbergstrom@...dia.com>
Terje
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists