linux-kernel - RE: [f2fs-dev] [PATCH V2] f2fs: check all ones or zeros bitmap with bitops for better mount performance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <003501ced384$31fb7530$95f25f90$@samsung.com>
Date:	Mon, 28 Oct 2013 11:19:56 +0900
From:	이창만 <cm224.lee@...sung.com>
To:	'Chao Yu' <chao2.yu@...sung.com>, jaegeuk.kim@...sung.com
Cc:	linux-fsdevel@...r.kernel.org,
	'谭姝' <shu.tan@...sung.com>,
	linux-kernel@...r.kernel.org,
	linux-f2fs-devel@...ts.sourceforge.net
Subject: RE: [f2fs-dev] [PATCH V2] f2fs: check all ones or zeros bitmap with
 bitops for better mount performance

To check whether bitmap are all zeros or all ones, I think memcmp is more neat.
But I don't know exactly performance gap between memcmp and find_next_bit.


-----Original Message-----
From: Chao Yu [mailto:chao2.yu@...sung.com] 
Sent: Thursday, October 24, 2013 5:21 PM
To: jaegeuk.kim@...sung.com
Cc: linux-fsdevel@...r.kernel.org; '谭姝'; linux-kernel@...r.kernel.org; linux-f2fs-devel@...ts.sourceforge.net
Subject: [f2fs-dev] [PATCH V2] f2fs: check all ones or zeros bitmap with bitops for better mount performance

Previously, check_block_count check valid_map with bit data type in common scenario that sit has all ones or zeros bitmap, it makes low mount performance.
So let's check the special bitmap with integer data type instead of the bit one.

v2:
    use find_next_bit_le/find_next_zero_bit_le for better performance and readable as Jaegeuk suggested.

Suggested-by: Jaegeuk Kim <jaegeuk.kim@...sung.com>
Signed-off-by: Tan Shu <shu.tan@...sung.com>
Signed-off-by: Yu Chao <chao2.yu@...sung.com>
---
 fs/f2fs/segment.h |   17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/fs/f2fs/segment.h b/fs/f2fs/segment.h index 7f94d78..d25b6af 100644
--- a/fs/f2fs/segment.h
+++ b/fs/f2fs/segment.h
@@ -552,6 +552,23 @@ static inline void check_block_count(struct f2fs_sb_info *sbi,
 	/* check boundary of a given segment number */
 	BUG_ON(segno > end_segno);
 
+	/* check all ones or zeros valid_map */
+	if (GET_SIT_VBLOCKS(raw_sit) == 0) {
+		int pos = find_next_bit_le(&raw_sit->valid_map,
+					sbi->blocks_per_seg,
+					0);
+		if (pos != sbi->blocks_per_seg)
+			BUG();
+		return;
+	} else if (GET_SIT_VBLOCKS(raw_sit) == sbi->blocks_per_seg) {
+		int pos = find_next_zero_bit_le(&raw_sit->valid_map,
+					sbi->blocks_per_seg,
+					0);
+		if (pos != sbi->blocks_per_seg)
+			BUG();
+		return;
+	}
+
 	/* check bitmap with valid block count */
 	for (i = 0; i < sbi->blocks_per_seg; i++)
 		if (f2fs_test_bit(i, raw_sit->valid_map))
--
1.7.9.5


------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from 
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60135991&iu=/4140/ostg.clktrk
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@...ts.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/