| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20131028023734.GA15642@weiyang.vnet.ibm.com> Date: Mon, 28 Oct 2013 10:37:35 +0800 From: Wei Yang <weiyang@...ux.vnet.ibm.com> To: Tejun Heo <tj@...nel.org> Cc: Wei Yang <weiyang@...ux.vnet.ibm.com>, cl@...ux-foundation.org, linux-mm@...ck.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 2/3] percpu: merge two loops when setting up group info On Sun, Oct 27, 2013 at 08:35:42AM -0400, Tejun Heo wrote: >On Mon, Oct 21, 2013 at 04:58:12PM +0800, Wei Yang wrote: >> There are two loops setting up the group info of pcpu_alloc_info. They share >> the same logic, so merge them could be time efficient when there are many >> groups. >> >> This patch merge these two loops into one. > >It *looks* correct to me but I'd rather not change this unless you can >show me this actually matters, which I find extremely doubtful given >nr_groups would be in the order of few thousands even on an extremely >large machine. Tejun, thanks for your review and comments. I agree with you that the nr_groups won't be very large, which means it will not bring many benefits. This is just a small code refine. If you don't like it, just drop it :-) > >Thanks. > >-- >tejun -- Richard Yang Help you, Help me -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists