linux-kernel - Re: [v1 1/2] xen/p2m: Create identity mappings for PFNs beyound E820 and PCI BARs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <526E41AB02000078000FD2E4@nat28.tlf.novell.com>
Date:	Mon, 28 Oct 2013 09:51:23 +0000
From:	"Jan Beulich" <JBeulich@...e.com>
To:	"Bjorn Helgaas" <bhelgaas@...gle.com>,
	"Konrad Rzeszutek Wilk" <konrad.wilk@...cle.com>
Cc:	"David Vrabel" <david.vrabel@...rix.com>,
	<Santosh.Jodh@...rix.com>, <xhejtman@....muni.cz>,
	"xen-devel" <xen-devel@...ts.xensource.com>,
	<boris.ostrovsky@...cle.com>, <mukesh.rathor@...cle.com>,
	<yuval.shaia@...cle.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [v1 1/2] xen/p2m: Create identity mappings for PFNs
 beyound E820 and PCI BARs

>>> On 26.10.13 at 00:08, Bjorn Helgaas <bhelgaas@...gle.com> wrote:
> On Fri, Oct 25, 2013 at 9:03 AM, Konrad Rzeszutek Wilk <konrad.wilk@...cle.com> wrote:
>> +               unsigned long pfn, start, end, ok_pfns;
>> +               char bus_addr[64];
>> +               char *fmt;
>> +
>> +               if (!pci_resource_len(pci_dev, i))
>> +                       continue;
>> +
>> +               if (pci_resource_flags(pci_dev, i) == IORESOURCE_IO)
> 
> You probably want:
> 
>     if (pci_resource_flags(pci_dev, i) & IORESOURCE_IO)
> 
> here.  And I don't understand what you're doing below, but my
> impression is you only care about MEM regions, not IO regions, so it
> seems like you might want to skip IO completely.

Yes indeed.

Jan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/