linux-kernel - RE: [PATCH 7/8] rds: Pass pointers to virt_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <72e26ba4-7b4f-4b64-b58c-0042cbe89202@default>
Date:	Mon, 28 Oct 2013 07:22:55 -0700 (PDT)
From:	Venkat Venkatsubra <venkat.x.venkatsubra@...cle.com>
To:	David Miller <davem@...emloft.net>, ben@...adent.org.uk
Cc:	linux-kernel@...r.kernel.org, rds-devel@....oracle.com,
	netdev@...r.kernel.org
Subject: RE: [PATCH 7/8] rds: Pass pointers to virt_to_page(), not integers

-----Original Message-----
From: David Miller [mailto:davem@...emloft.net] 
Sent: Sunday, October 27, 2013 11:27 PM
To: ben@...adent.org.uk
Cc: Venkat Venkatsubra; linux-kernel@...r.kernel.org; rds-devel@....oracle.com; netdev@...r.kernel.org
Subject: Re: [PATCH 7/8] rds: Pass pointers to virt_to_page(), not integers

From: Ben Hutchings <ben@...adent.org.uk>
Date: Sun, 27 Oct 2013 21:54:16 +0000

> Most architectures define virt_to_page() as a macro that casts its 
> argument such that an argument of type unsigned long will be accepted 
> without complaint.  However, the proper type is void *, and passing 
> unsigned long results in a warning on MIPS.
> 
> Compile-tested only.
> 
> Signed-off-by: Ben Hutchings <ben@...adent.org.uk>

This looks fine:

Acked-by: David S. Miller <davem@...emloft.net>
Acked-by: Venkat Venkatsubra <venkat.x.venkatsubra@...cle.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/