lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 28 Oct 2013 08:33:20 -0700 From: Stephen Hemminger <stephen@...workplumber.org> To: Johannes Berg <johannes@...solutions.net> Cc: Dan Williams <dcbw@...hat.com>, Pali Rohár <pali.rohar@...il.com>, Luciano Coelho <luca@...lho.fi>, "John W. Linville" <linville@...driver.com>, "David S. Miller" <davem@...emloft.net>, linux-wireless@...r.kernel.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, freemangordon@....bg, aaro.koskinen@....fi, pavel@....cz, sre@...g0.de, joni.lapilainen@...il.com Subject: Re: [PATCH 16/16] wl1251: Add sysfs file address for setting permanent mac address On Mon, 28 Oct 2013 15:56:55 +0100 Johannes Berg <johannes@...solutions.net> wrote: > On Mon, 2013-10-28 at 09:46 -0500, Dan Williams wrote: > > > If the device doesn't actually *have* a permanent MAC address, then it > > shouldn't be returning one via ethtool, and should return an error for > > ETHTOOL_GPERMADDR. > > There's currently no provision for that, but I agree it would be better > to do so. > > johannes > > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@...r.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html The current netdevice API handle the case of a device without a permanent MAC address, slightly differently. If device does not have a permanent address, then: 1. dev->addr_assign_type should not be NET_ADDR_PERM 2. when device is registered dev->perm_addr will not be set and retain all zeros value 4. when ethtool gets address it will return all zeros which is not a valid address. This case doesn't seem to be handled threo mac80211 API's -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists