linux-kernel - [PATCH] lib/scatterlist.c: don't flush_kernel_dcache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1382977205-26268-1-git-send-email-ming.lei@canonical.com>
Date:	Tue, 29 Oct 2013 00:20:05 +0800
From:	Ming Lei <ming.lei@...onical.com>
To:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Ming Lei <ming.lei@...onical.com>,
	Russell King - ARM Linux <linux@....linux.org.uk>,
	linux-arm-kernel@...ts.infradead.org,
	Simon Baatz <gmbnomis@...il.com>,
	Will Deacon <will.deacon@....com>,
	Aaro Koskinen <aaro.koskinen@....fi>,
	Catalin Marinas <catalin.marinas@....com>,
	FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>,
	Tejun Heo <tj@...nel.org>,
	"James E.J. Bottomley" <JBottomley@...allels.com>,
	Jens Axboe <axboe@...nel.dk>
Subject: [PATCH] lib/scatterlist.c: don't flush_kernel_dcache_page on slab page

Commit b1adaf65ba03([SCSI] block: add sg buffer copy helper functions)
introduces two sg buffer copy helpers, and calls flush_kernel_dcache_page()
on pages in SG list after these pages are written to.

Unfortunately, the commit may introduce a potential bug:

	- Before sending some SCSI commands, kmalloc() buffer may be
	passed to block layper, so flush_kernel_dcache_page() can
	see a slab page finally

	- According to cachetlb.txt, flush_kernel_dcache_page() is
	only called on "a user page", which surely can't be a slab page.

	- ARCH's implementation of flush_kernel_dcache_page() may
	use page mapping information to do optimization so page_mapping()
	will see the slab page, then VM_BUG_ON() is triggered.

Aaro Koskinen reported the bug on ARM/kirkwood when DEBUG_VM is enabled,
and this patch fixes the bug by adding test of '!PageSlab(miter->page)'
before calling flush_kernel_dcache_page().

Reported-by: Aaro Koskinen <aaro.koskinen@....fi>
Cc: Russell King - ARM Linux <linux@....linux.org.uk>
Cc: linux-arm-kernel@...ts.infradead.org
Cc: Simon Baatz <gmbnomis@...il.com>
Cc: Will Deacon <will.deacon@....com>
Cc: Aaro Koskinen <aaro.koskinen@....fi>
Cc: Catalin Marinas <catalin.marinas@....com>
Cc: Andrew Morton <akpm@...ux-foundation.org>
Cc: FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>
Cc: Tejun Heo <tj@...nel.org>
Cc: "James E.J. Bottomley" <JBottomley@...allels.com>
Cc: Jens Axboe <axboe@...nel.dk>
Signed-off-by: Ming Lei <ming.lei@...onical.com>
---
 lib/scatterlist.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lib/scatterlist.c b/lib/scatterlist.c
index a685c8a..d16fa29 100644
--- a/lib/scatterlist.c
+++ b/lib/scatterlist.c
@@ -577,7 +577,8 @@ void sg_miter_stop(struct sg_mapping_iter *miter)
 		miter->__offset += miter->consumed;
 		miter->__remaining -= miter->consumed;
 
-		if (miter->__flags & SG_MITER_TO_SG)
+		if ((miter->__flags & SG_MITER_TO_SG) &&
+		    !PageSlab(miter->page))
 			flush_kernel_dcache_page(miter->page);
 
 		if (miter->__flags & SG_MITER_ATOMIC) {
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/