| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <1382977710-1966-1-git-send-email-vladimir_zapolskiy@mentor.com> Date: Mon, 28 Oct 2013 18:28:30 +0200 From: Vladimir Zapolskiy <vladimir_zapolskiy@...tor.com> To: <linux-kernel@...r.kernel.org> CC: Greg Kroah-Hartman <gregkh@...uxfoundation.org> Subject: [PATCH] sysfs: return correct error code on unimplemented mmap() Both POSIX.1-2008 and Linux Programmer's Manual have a dedicated return error code for a case, when a file doesn't support mmap(), it's ENODEV. This change replaces overloaded EINVAL with ENODEV in a situation described above for sysfs binary files. Signed-off-by: Vladimir Zapolskiy <vladimir_zapolskiy@...tor.com> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org> --- fs/sysfs/bin.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/sysfs/bin.c b/fs/sysfs/bin.c index c590cab..d37433c 100644 --- a/fs/sysfs/bin.c +++ b/fs/sysfs/bin.c @@ -350,7 +350,6 @@ static int mmap(struct file *file, struct vm_area_struct *vma) if (!sysfs_get_active(attr_sd)) goto out_unlock; - rc = -EINVAL; if (!attr->mmap) goto out_put; -- 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists