linux-kernel - Re: [PATCH]tty:vt: Add NULL check to return value of kzalloc()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20131028163510.GB4797@kroah.com>
Date:	Mon, 28 Oct 2013 09:35:10 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Wang YanQing <udknight@...il.com>, rucsoftsec@...il.com,
	jslaby@...e.cz, airlied@...hat.com, akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH]tty:vt: Add NULL check to return value of kzalloc()

On Tue, Oct 29, 2013 at 12:26:05AM +0800, Wang YanQing wrote:
> In extreme situation kzalloc in con_init may
> return NULL, so we should check it to prevent
> OOPS!
> 
> Signed-off-by: Wang YanQing <udknight@...il.com>
> Reported-by: rucsoftsec@...il.com

I need a name for Reported-by: as well, not just an email.

> ---
>  I don't think a system without memory to initialize
>  vt could do some useful things, but this patch could
>  make debug easier and improve kernel code's robustness 
>  in theory.

Please always run your patches through the scripts/checkpatch.pl tool
and fix the problems found there so that maintainers don't have to point
out the same thing...

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/