linux-kernel - Re: [f2fs-dev 5/5] f2fs: Handle inline data operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+v9cxYUJ20_N5Zbo1W4WbTDB_SgXsbngZ0fEJx0dk+sxTS_1g@mail.gmail.com>
Date:	Tue, 29 Oct 2013 00:56:55 +0800
From:	Huajun Li <huajun.li.lee@...il.com>
To:	"jaegeuk.kim" <jaegeuk.kim@...sung.com>
Cc:	linux-f2fs-devel <linux-f2fs-devel@...ts.sourceforge.net>,
	linux-fsdevel <linux-fsdevel@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Huajun Li <huajun.li@...el.com>,
	Haicheng Li <haicheng.li@...ux.intel.com>,
	Weihong Xu <weihong.xu@...el.com>
Subject: Re: [f2fs-dev 5/5] f2fs: Handle inline data operations

On Mon, Oct 28, 2013 at 8:44 PM, Jaegeuk Kim <jaegeuk.kim@...sung.com> wrote:
> Hi,
>
> 2013-10-26 (토), 00:01 +0800, Huajun Li:
>> From: Huajun Li <huajun.li@...el.com>
>>
>
> [snip]
>
>>
>> @@ -538,7 +553,7 @@ static int f2fs_write_data_page(struct page *page,
>>       loff_t i_size = i_size_read(inode);
>>       const pgoff_t end_index = ((unsigned long long) i_size)
>>                                                       >> PAGE_CACHE_SHIFT;
>> -     unsigned offset;
>> +     unsigned offset = 0;
>>       bool need_balance_fs = false;
>>       int err = 0;
>>
>> @@ -572,7 +587,14 @@ write:
>>               err = do_write_data_page(page);
>>       } else {
>>               f2fs_lock_op(sbi);
>> -             err = do_write_data_page(page);
>> +             if (test_opt(sbi, INLINE_DATA) && (i_size <= MAX_INLINE_DATA)) {
>> +                     err = f2fs_write_inline_data(inode, page, offset);
>> +                     ClearPageDirty(page);
>
> Don't need to call ClearPageDirty(page).
>

Yes. I will remove it in next version, thanks.

>> +                     f2fs_unlock_op(sbi);
>> +                     goto out;
>> +             } else {
>> +                     err = do_write_data_page(page);
>> +             }
>>               f2fs_unlock_op(sbi);
>>               need_balance_fs = true;
>>
> --
> Jaegeuk Kim
> Samsung
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/