| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <526E97F4.3050104@kernel.dk> Date: Mon, 28 Oct 2013 10:59:32 -0600 From: Jens Axboe <axboe@...nel.dk> To: Christoph Hellwig <hch@...radead.org> CC: Alexander Gordeev <agordeev@...hat.com>, Tejun Heo <tj@...nel.org>, Nicholas Bellinger <nab@...ux-iscsi.org>, linux-kernel@...r.kernel.org Subject: Re: blk-mq flush fix On 10/28/2013 10:46 AM, Christoph Hellwig wrote: > On Mon, Oct 28, 2013 at 10:29:11AM -0600, Jens Axboe wrote: >> It's not that I think the existing patch is THAT bad, it fits in alright >> with the reserved tagging and works regardless of whether a driver uses >> reserved tags or not. And it does have the upside of not requiring >> special checks or logic for this special non-tagged request that using >> the preallocated would might need. > > The problem with it is that it will pass a tag number to the low level > driver which it doesn't expect. In case the tags are used 1:1 as > hardware tags that would lead to nasy bugs. > > At vefy least we'd need to mess with ->tag for this special request. Yes indeed. Actually the more I think about it, the better I like just using the normal tagging infrastructure and punting to a reserved tag for the flush. Just needs adding of the check whether it actually needs it or not. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists