linux-kernel - Re: [PATCH 3.12] cfg80211: fix ibss wext chandef creation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ghtxg12u7x.fsf@lena.gouders.net>
Date:	Mon, 28 Oct 2013 18:14:42 +0100
From:	Dirk Gouders <dirk@...ders.net>
To:	Johannes Berg <johannes@...solutions.net>
Cc:	Simon Wunderlich <sw@...onwunderlich.de>,
	linux-wireless@...r.kernel.org,
	Mathias Kretschmer <mathias.kretschmer@...us.fraunhofer.de>,
	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3.12] cfg80211: fix ibss wext chandef creation

Johannes Berg <johannes@...solutions.net> writes:

> On Tue, 2013-10-22 at 22:02 +0200, Simon Wunderlich wrote:
>> The wext internal chandefs for ibss should be created using the
>> cfg80211_chandef_create() functions. Otherwise the center_freq1 field
>> will not be set and cfg80211_chandef_valid() will spit a warning and
>> report the chandef as invalid when it should be used.
>
> I think
>
> commit f478f33a93f9353dcd1fe55445343d76b1c3f84a
> Author: Bruno Randolf <br1@...fach.org>
> Date:   Thu Sep 26 16:55:28 2013 +0100
>
>     cfg80211: fix warning when using WEXT for IBSS
>
>
> already fixed this. Your patch doesn't apply, but feel free to send me a
> new one (for -next) converting to the creation helpers.

I tested the above commit and it also fixes the problems I noticed here.

Best regards,

Dirk
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/