linux-kernel - Re: [PATCH 3/4] VFIO: pci: amend vfio-pci for explicit binding via sysfs only

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 28 Oct 2013 11:47:42 -0600
From:	Alex Williamson <alex.williamson@...hat.com>
To:	Kim Phillips <kim.phillips@...aro.org>
Cc:	Bhushan Bharat <R65777@...escale.com>,
	Wood Scott <B07421@...escale.com>,
	Yoder Stuart <B08248@...escale.com>,
	christoffer.dall@...aro.org, linux-kernel@...r.kernel.org,
	a.motakis@...tualopensystems.com, agraf@...e.de,
	Sethi Varun <B16395@...escale.com>, peter.maydell@...aro.org,
	santosh.shukla@...aro.org, kvm@...r.kernel.org,
	gregkh@...uxfoundation.org
Subject: Re: [PATCH 3/4] VFIO: pci: amend vfio-pci for explicit binding via
 sysfs only

On Fri, 2013-10-11 at 01:27 -0500, Kim Phillips wrote:
> Force the vfio-pci driver to only be bound explicitly via sysfs to avoid
> conflics with other drivers in the event of a hotplug.

We can't break userspace, so we can't disable the current method of
binding devices to vfio-pci.  We can add a new method and perhaps
deprecate the existing mechanism to be removed at some point in the
future.  Thanks,

Alex

> Signed-off-by: Kim Phillips <kim.phillips@...aro.org>
> ---
>  drivers/vfio/pci/vfio_pci.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/vfio/pci/vfio_pci.c b/drivers/vfio/pci/vfio_pci.c
> index 6ab71b9..bdd7833 100644
> --- a/drivers/vfio/pci/vfio_pci.c
> +++ b/drivers/vfio/pci/vfio_pci.c
> @@ -901,6 +901,9 @@ static struct pci_driver vfio_pci_driver = {
>  	.probe		= vfio_pci_probe,
>  	.remove		= vfio_pci_remove,
>  	.err_handler	= &vfio_err_handlers,
> +	.driver = {
> +		.sysfs_bind_only = true,
> +	},
>  };
>  
>  static void __exit vfio_pci_cleanup(void)



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/