linux-kernel - Re: [PATCH v4 2/3] Support for perf to probe into SDT markers:

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <526EB0C3.2080304@iki.fi>
Date:	Mon, 28 Oct 2013 20:45:23 +0200
From:	Pekka Enberg <penberg@....fi>
To:	David Ahern <dsahern@...il.com>,
	Srikar Dronamraju <srikar@...ux.vnet.ibm.com>
CC:	Hemant Kumar <hkshaw@...ux.vnet.ibm.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Oleg Nesterov <oleg@...hat.com>,
	"hegdevasant@...ux.vnet.ibm.com" <hegdevasant@...ux.vnet.ibm.com>,
	Ingo Molnar <mingo@...hat.com>,
	"anton@...hat.com" <anton@...hat.com>,
	"systemtap@...rceware.org" <systemtap@...rceware.org>,
	Namhyung Kim <namhyung@...nel.org>,
	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>,
	"aravinda@...ux.vnet.ibm.com" <aravinda@...ux.vnet.ibm.com>
Subject: Re: [PATCH v4 2/3] Support for perf to probe into SDT markers:

On 10/28/13 6:59 PM, David Ahern wrote:
 > I often use perf-list to lookup an exact event name, and I do not want
 > to see it taking many seconds to minutes to run (not everyone is
 > running on an SSD). I also run perf on many different OS versions with
 > an NFS home directory, and do not want to see a cache explosion (I
 > have buildid disabled for this reason).

I am talking about reasonable defaults - the 'default' part implies that
people can change the behavior.  So we absolutely should also have
something like this for power users such as yourself:

   perf config sdt.scan false

That said, the 'reasonable' part suggests that 'perf list' must not take
seconds or minutes (!) for every run.  I'd start with implementing a
naive scan and seeing where it takes us.  It's not like it's rocket
science to ignore network mounts or revert to a whitelist of paths if
necessary.

As for cache explosion, I don't see what the problem is.

If you build a cache of DSOs and executables that have SDT makers (with a
SHA1 hash), the cache size bound by SDT marker annotated files.  You
probably can then unconditionally scan the cached filenames for SDT
markers for 'perf list'. And once you see a SHA1 mismatch, you either
rescan automatically or explain to the user that:

   SDT marker cache needs to be updated. Please run 'perf list --scan'.

Transparently supporting SDT markers as events for 'perf trace -e' and
others is slightly more tricky because you probably don't want to scan
the files for every 'perf trace' invocation.  However, you can probably
get really far with a 1024-entry SDT marker cache that's separate from
the 'executables and DSOs with SDT markers' cache. So whenever the user
does something like

   perf trace -e libc:setjmp sleep 1

The 'libc:setjmp' ends up in the 1024-entry cache (or whatever makes
most sense) that points directly to SDT marker so we can hook into it
quickly.  Using simple LRU eviction policy, you end up pushing out the
uninteresting SDT markers and keeping the ones that are used all the
time.

                         Pekka

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/