linux-kernel - Re: [PATCH 1/2] mmc: arasan: Add driver for Arasan SDHCI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1873048.2t2L2zW4W9@flatron>
Date:	Mon, 28 Oct 2013 23:19:13 +0100
From:	Tomasz Figa <tomasz.figa@...il.com>
To:	Sören Brinkmann <soren.brinkmann@...inx.com>
Cc:	Rob Herring <rob.herring@...xeda.com>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Stephen Warren <swarren@...dotorg.org>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Rob Landley <rob@...dley.net>,
	Russell King <linux@....linux.org.uk>,
	Chris Ball <cjb@...top.org>,
	Michal Simek <michal.simek@...inx.com>,
	Grant Likely <grant.likely@...aro.org>,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-mmc@...r.kernel.org, linux-doc@...r.kernel.org,
	devicetree@...r.kernel.org
Subject: Re: [PATCH 1/2] mmc: arasan: Add driver for Arasan SDHCI

On Monday 28 of October 2013 14:47:38 Sören Brinkmann wrote:
> On Mon, Oct 28, 2013 at 10:16:49PM +0100, Tomasz Figa wrote:
> > Hi Soren,
> > 
> > On Tuesday 15 of October 2013 12:08:04 Soren Brinkmann wrote:
> > > Add a driver for Arasan's SDHCI controller core.
> > > 
> > > Signed-off-by: Soren Brinkmann <soren.brinkmann@...inx.com>
> > > ---
> > > 
> > >  .../devicetree/bindings/mmc/arasan,sdhci.txt       |  23 +++
> > >  MAINTAINERS                                        |   1 +
> > >  drivers/mmc/host/Kconfig                           |  12 ++
> > >  drivers/mmc/host/Makefile                          |   1 +
> > >  drivers/mmc/host/sdhci-of-arasan.c                 | 224
> > > 
> > > +++++++++++++++++++++ 5 files changed, 261 insertions(+)
> > > 
> > >  create mode 100644
> > > 
> > > Documentation/devicetree/bindings/mmc/arasan,sdhci.txt create mode
> > > 100644 drivers/mmc/host/sdhci-of-arasan.c
> > > 
> > > diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
> > > b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt new file
> > > mode
> > > 100644
> > > index 000000000000..20f0fc25e270
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
> > > @@ -0,0 +1,23 @@
> > > +Device Tree Bindings for the Arasan SDCHI Controller
> > > +
> > > +  The bindings follow the mmc[1] and the clock bindings[2]. Only
> > > deviations are +  documented here.
> > > +
> > > +  [1] Documentation/devicetree/bindings/mmc/mmc.txt
> > > +  [2] Documentation/devicetree/bindings/clock/clock-bindings.txt
> > > +
> > 
> > > +Required Properties:
> > According to the example below, the list of required properties lacks
> > interrupt-related properties.
> 
> Well, the interrupt bindings seem to differ between platforms and
> architecture and looking at documentation for other sdhci bindings it
> seemed to be okay to avoid documenting them in this place.

Sure, but I believe that this controller always has an interrupt signal, 
so at least it should be marked that interrupts need to be specified.

Best regards,
Tomasz

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/