linux-kernel - Re: [PATCH] mm: cma: free cma page to buddy instead of being cpu hot page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <526F58B5.7020503@jp.fujitsu.com>
Date:	Tue, 29 Oct 2013 02:41:57 -0400
From:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
To:	minchan@...nel.org, zhang.mingjun@...aro.org
CC:	m.szyprowski@...sung.com, akpm@...ux-foundation.org,
	mgorman@...e.de, haojian.zhuang@...aro.org, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org, troy.zhangmingjun@...aro.org
Subject: Re: [PATCH] mm: cma: free cma page to buddy instead of being cpu
 hot page

> The concern is likely/unlikely usage is proper in this code peice.
> If we don't use memory isolation, the code path is used for only
> MIGRATE_RESERVE which is very rare allocation in normal workload.
> 
> Even, in memory isolation environement, I'm not sure how many
> CMA/HOTPLUG is used compared to normal alloc/free.
> So, I think below is more proper?
> 
> if (unlikely(migratetype >= MIGRATE_PCPTYPES)) {
>         if (is_migrate_isolate(migratetype) || is_migrate_cma(migratetype))
> 
> I know it's an another topic but I'd like to disucss it in this time because
> we will forget such trivial thing later, again.

I completely agree with this.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/