linux-kernel - Re: [PATCH] arch: use ASM_NL instead of ';' for assembler new line character in the macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 29 Oct 2013 09:04:56 +0800
From:	Chen Gang <gang.chen@...anux.com>
To:	Vineet Gupta <vineetg76@...il.com>
CC:	Chen Gang <gang.chen@...anux.com>,
	James Hogan <james.hogan@...tec.com>,
	Al Viro <viro@...iv.linux.org.uk>,
	Arnd Bergmann <arnd@...db.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Linux-Arch <linux-arch@...r.kernel.org>,
	Max Filippov <jcmvbkbc@...il.com>
Subject: Re: [PATCH] arch: use ASM_NL instead of ';' for assembler new line
 character in the macro

On 10/28/2013 09:45 PM, Vineet Gupta wrote:
> On 10/28/2013 04:00 PM, Chen Gang wrote:
>> For some toolchains, they use another character as newline in a macro
>> (e.g. arc uses '`'), so for generic assembly code, need use ASM_NL (a
>> macro) instead of ';' for it.
>>
>> Since "linux/export.h" are mainly used for exporting work, then our fix
>> more likely belongs to "linux/linkage.h", and we need add the related
>> checking in "linkage.h".
>>
>> Also need notice 80 columns wrap, and '\t' for each line.
>>
>>
>> Signed-off-by: Chen Gang <gang.chen@...anux.com>
>> ---
>>  arch/arc/include/asm/linkage.h    |    2 +
>>  include/asm-generic/vmlinux.lds.h |  350 +++++++++++++++++++------------------
>>  include/linux/linkage.h           |   19 +
> 
> Like Max said, please drop the linker script bits - they are OK - otherwise ARC
> kernel won't have been building at all.
> 

OK, thank you and Max, I will send patch v2 for it.

Hmm... after this modification, it passed allmodconfig for x86_64. And
for arc, at least, it can build to "mm/" sub-directory (after here, I
stopped compiling).


> And you also need to fix kernel/modsign_certificate.S as part of same patchset as
> that is where the problem started in first place.
> 

Hmm... can that be another patch?

For "kernel/modsign_certificate.S", I recommend to expand the macro
which will shrink code line, either need not include additional header
file, I feel that will be simpler for both code reader and writers.


Thanks.
-- 
Chen Gang
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/