linux-kernel - Re: [PATCH 3/6] perf timechart: add support for displaying only tasks related data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131029093329.GC3406@stfomichev-desktop>
Date:	Tue, 29 Oct 2013 13:33:29 +0400
From:	Stanislav Fomichev <stfomichev@...dex-team.ru>
To:	Namhyung Kim <namhyung@...nel.org>
Cc:	a.p.zijlstra@...llo.nl, paulus@...ba.org, mingo@...hat.com,
	acme@...stprotocols.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/6] perf timechart: add support for displaying only
 tasks related data

> Hmm.. double negation is always confusing to me. :-/  How about making
> it a boolean option that sets "task_only" variable?
Ok.

> Also need to update the doc.  And what if user gives -P and -T options
> at the same time?
Is something like this is enough (or you'd like some printout with error
details)?

if (!proc_num && task_only)
		usage_with_options(timechart_usage, options);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/