linux-kernel - Re: [PATCH 5/6] perf timechart: add support for -P and -T in timechart recording

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131029095156.GE3406@stfomichev-desktop>
Date:	Tue, 29 Oct 2013 13:51:56 +0400
From:	Stanislav Fomichev <stfomichev@...dex-team.ru>
To:	Namhyung Kim <namhyung@...nel.org>
Cc:	a.p.zijlstra@...llo.nl, paulus@...ba.org, mingo@...hat.com,
	acme@...stprotocols.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/6] perf timechart: add support for -P and -T in
 timechart recording

> It should be ARRAY_SIZE(old_power_args).
Thanks :-)

> Do we really need to separate the option and usage for record?  AFAICS
> it does exactly same thing..
Yes, we do. Some options which are defined for timechart are undefined
for record (like -i, -o, etc), so we want to get an error in case of wrong
options.

And we separate usage, because it's different in timechart:
		"perf timechart [<options>] {record}",

and record:
		"perf timechart record [<options>]",

We may share usage, but we need it to be something (confusing?) like:
		"perf timechart [<options>] {record [<options>]}",
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/