linux-kernel - Re: [PATCH 1/2] framebuffer: Add fb_<level> convenience logging macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <526F9455.7070103@ti.com>
Date:	Tue, 29 Oct 2013 12:56:21 +0200
From:	Tomi Valkeinen <tomi.valkeinen@...com>
To:	Joe Perches <joe@...ches.com>,
	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>
CC:	<linux-fbdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] framebuffer: Add fb_<level> convenience logging macros

On 20/09/13 04:35, Joe Perches wrote:
> Add fb_<level> convenience macros for emitting the
> "fb%d: ", struct fb_info->node value.
> 
> Neatens and shortens the code a bit.
> 
> Signed-off-by: Joe Perches <joe@...ches.com>
> ---
>  include/linux/fb.h | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/include/linux/fb.h b/include/linux/fb.h
> index ffac70a..70c4836 100644
> --- a/include/linux/fb.h
> +++ b/include/linux/fb.h
> @@ -792,4 +792,16 @@ extern int fb_find_mode(struct fb_var_screeninfo *var,
>  			const struct fb_videomode *default_mode,
>  			unsigned int default_bpp);
>  
> +/* Convenience logging macros */
> +#define fb_err(fb_info, fmt, ...)					\
> +	pr_err("fb%d: " fmt, (fb_info)->node, ##__VA_ARGS__)
> +#define fb_notice(info, fmt, ...)					\
> +	pr_notice("fb%d: " fmt, (fb_info)->node, ##__VA_ARGS__)
> +#define fb_warn(fb_info, fmt, ...)					\
> +	pr_warn("fb%d: " fmt, (fb_info)->node, ##__VA_ARGS__)
> +#define fb_info(fb_info, fmt, ...)					\
> +	pr_info("fb%d: " fmt, (fb_info)->node, ##__VA_ARGS__)
> +#define fb_dbg(fb_info, fmt, ...)					\
> +	pr_debug("fb%d: " fmt, (fb_info)->node, ##__VA_ARGS__)
> +
>  #endif /* _LINUX_FB_H */
> 

Thanks, queued this and the next one for 3.13.

 Tomi



Download attachment "signature.asc" of type "application/pgp-signature" (902 bytes)