linux-kernel - Re: [PATCH 1/2] mmc: arasan: Add driver for Arasan SDHCI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ff1f2d38-4185-49f0-8b63-b3bd2b4f9a27@CO9EHSMHS024.ehs.local>
Date:	Mon, 28 Oct 2013 17:15:52 -0700
From:	Sören Brinkmann <soren.brinkmann@...inx.com>
To:	Rob Herring <robherring2@...il.com>
CC:	Rob Herring <rob.herring@...xeda.com>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Stephen Warren <swarren@...dotorg.org>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Rob Landley <rob@...dley.net>,
	Russell King <linux@....linux.org.uk>,
	Chris Ball <cjb@...top.org>,
	Michal Simek <michal.simek@...inx.com>,
	Grant Likely <grant.likely@...aro.org>,
	<devicetree@...r.kernel.org>, <linux-mmc@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>, <linux-doc@...r.kernel.org>
Subject: Re: [PATCH 1/2] mmc: arasan: Add driver for Arasan SDHCI

On Mon, Oct 28, 2013 at 06:20:41PM -0500, Rob Herring wrote:
> On 10/15/2013 02:08 PM, Soren Brinkmann wrote:
> > Add a driver for Arasan's SDHCI controller core.
> > 
> > Signed-off-by: Soren Brinkmann <soren.brinkmann@...inx.com>
> > ---
> >  .../devicetree/bindings/mmc/arasan,sdhci.txt       |  23 +++
> >  MAINTAINERS                                        |   1 +
> >  drivers/mmc/host/Kconfig                           |  12 ++
> >  drivers/mmc/host/Makefile                          |   1 +
> >  drivers/mmc/host/sdhci-of-arasan.c                 | 224 +++++++++++++++++++++
> >  5 files changed, 261 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
> >  create mode 100644 drivers/mmc/host/sdhci-of-arasan.c
> > 
> > diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
> > new file mode 100644
> > index 000000000000..20f0fc25e270
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
> > @@ -0,0 +1,23 @@
> > +Device Tree Bindings for the Arasan SDCHI Controller
> > +
> > +  The bindings follow the mmc[1] and the clock bindings[2]. Only deviations are
> > +  documented here.
> > +
> > +  [1] Documentation/devicetree/bindings/mmc/mmc.txt
> > +  [2] Documentation/devicetree/bindings/clock/clock-bindings.txt
> > +
> > +Required Properties:
> > +  - compatible: Compatibility string. Must be 'arasan,sdhci'
> 
> This string is a bit non-specific. Vendor IP typically has configurable
> options, different revs of IP with fixes/differences, and the
> possibility of integration wierdness or bugs. So it is better to be as
> specific as possible in case the kernel needs to know exactly what
> version of h/w this is.
Okay. The Zynq TRM specifies the version as '8.9A_apr02nd_2010', which seems
a little overly specific to me. How does 'arasan,sdhci-8.9a' sound to
you?

	Thanks,
	Sören


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/