linux-kernel - Re: [PATCH] genirq: Avoid NULL OOPS in irq handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1310291402490.8257@ionos.tec.linutronix.de>
Date:	Tue, 29 Oct 2013 14:07:00 +0100 (CET)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Huacai Chen <chenhc@...ote.com>
cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] genirq: Avoid NULL OOPS in irq handling

On Sat, 28 Sep 2013, Huacai Chen wrote:

> Some devices (e.g. serial port) setup irq handler at dev open and free
> it at dev close. So, sometimes there is no irqaction for a specific
> irq. But some buggy devices may send irqs at any time. This patch avoid
> the NULL OOPS when irqaction isn't registered.

All callers except the real per cpu interrupts are checking whether
there is a valid action before calling. And serial ports are not
routed to real per cpu interrupts. Can you provide more detailed
information about the problem you are trying to solve please?

Thanks,

	tglx

> Signed-off-by: Huacai Chen <chenhc@...ote.com>
> ---
>  kernel/irq/handle.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/kernel/irq/handle.c b/kernel/irq/handle.c
> index 131ca17..1c78e69 100644
> --- a/kernel/irq/handle.c
> +++ b/kernel/irq/handle.c
> @@ -135,6 +135,9 @@ handle_irq_event_percpu(struct irq_desc *desc, struct irqaction *action)
>  	irqreturn_t retval = IRQ_NONE;
>  	unsigned int flags = 0, irq = desc->irq_data.irq;
>  
> +	if (!action)
> +		goto out;
> +
>  	do {
>  		irqreturn_t res;
>  
> @@ -174,6 +177,7 @@ handle_irq_event_percpu(struct irq_desc *desc, struct irqaction *action)
>  
>  	add_interrupt_randomness(irq, flags);
>  
> +out:
>  	if (!noirqdebug)
>  		note_interrupt(irq, desc, retval);
>  	return retval;
> -- 
> 1.7.7.3
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/