linux-kernel - Re: [RFC/PATCH 2/2] usb: ffs/dwc3: pad epout buffer size when not aligned to maxpacketsize

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <526FC51A.2080008@linux.intel.com>
Date:	Tue, 29 Oct 2013 07:24:26 -0700
From:	David Cohen <david.a.cohen@...ux.intel.com>
To:	balbi@...com
CC:	gregkh@...uxfoundation.org, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [RFC/PATCH 2/2] usb: ffs/dwc3: pad epout buffer size when not
 aligned to maxpacketsize

>> +		/*
>> +		 * DWC3 requires buffer size to be aligned to maxpacketsize
>> +		 * of an out endpoint.
>> +		 * FIXME: a more generic solution might be necessary.
>> +		 */
> 
> see, gadget drivers shouldn't have to know about DWC3 at all. They need
> to know that current UDC has a quirk where EP OUT transactions need to
> be aligned to wMaxPacketSize, so what I was expecting to see here was:
> 
> 		if (test_bit(USB_GADGET_QUIRK_EP_OUT_ALIGNED_SIZE, &gadget->qirks) &&
> 			!IS_ALIGNED(len, ep->ep->desc->wMaxPacketSize))
> 			len = align_length(orig_len, wMaxPacketSize);

That makes sense. I'll send a new version.

Thanks,

David Cohen

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/